Conversation
ArthurKun21
force-pushed
the
update-support-icons
branch
from
4cbed5c to
346c09b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the support icons by switching to new assets with transparent backgrounds and using coil3's AsyncImage for rendering.
- Replaced the Image composable with AsyncImage from coil3.compose.
- Moved the alpha setting from the Modifier chain to the AsyncImage parameter.
- Added the required import for AsyncImage.
Comments suppressed due to low confidence (1)
app/src/main/java/io/github/fate_grand_automata/ui/battle_config_item/SupportGroup.kt:200
- Confirm that using AsyncImage with a direct resource reference (it.drawable) is supported as intended; verify that this change maintains proper handling of drawable resources.
AsyncImage(
wowuz
pushed a commit
to wowuz/FGA
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update support icons
Pull Request Type
Related issue
Description
Use much clearer asset with the transparent background
Screenshots
Testing
Additional context